JGR's Patch Pack

[fridaemon]

I've added a setting along these lines.

[Quast65]

As Santa is on his way, I want to start a new yearly tradition for me by summing up my wishlist for OpenTTD

In no particular order:
- Multicore Processor Support
- One-way Curves (and maybe also T- and X-Crossings)
- More Than 255 Active GRFs In A Game
- More Than 64 Road/Tram-type Slots (Or A Separate Menu For Eyecandy Roadoverlays)
- No Overhang Penalty For Long (PAX)Trains (Possibly As A Cheat)
- Variable Snowline WITH Snowy Coastlines
- Possibility To Give Objects (Maybe Also Other CC-Aware Structures) A Separate Colorscheme (Like With Vehicles)
- Via A Non-Running Animation, Objects Can Have Different Graphics When Placed Multiple Times On The Same Spot
Currently This "Animation" Randomly Picks A Frame Each Time You Place An Object, It Would Be Nice If It Follows The Sequence Of The Animation.

Merry Christmas!!

[uginbgood]

found bug in 0.56.1 with Newstations.

Без имени, 1980-01-01#1.png

(575.73 KiB) Not downloaded yet

. previously never had a problem with that grf.

grfs.png (14.75 KiB) Viewed 55705 times

[JGR]

found bug in 0.56.1 with Newstations. Без имени, 1980-01-01#1.png. previously never had a problem with that grf. grfs.png

This is a known issue, it will be fixed in the next release.
In the meantime you can type `set_newgrf_optimiser_flags 1` in the console to make it go away.

[uginbgood]

found bug in 0.56.1 with Newstations. Без имени, 1980-01-01#1.png. previously never had a problem with that grf. grfs.png

This is a known issue, it will be fixed in the next release.
In the meantime you can type `set_newgrf_optimiser_flags 1` in the console to make it go away.

it works. Thanx

[Lurkmore]

found bug in 0.56.1 with Newstations. Без имени, 1980-01-01#1.png. previously never had a problem with that grf. grfs.png

Where did you get that version of NewStations?

[Emperor Jake]

Where did you get that version of NewStations?

Same place where you get the rest of MB's stuff: http://ttdpatch.de/download.html

[Oakman]

First of all, thanks for the patch pack, great work.

One small proposal: Would it be possible to add a statistic regarding the amount a cargo that a train transports?
Something like the already existing "Lifetime profits" – it would be optimal to have in parallel the “Lifetime amount of transported cargo” and then this value divided by the age of the train.
The background of this proposal is that in case of complex, multi-step “Transfer”-Scenarios it would be great to be able to monitor the transport capability of the individual steps.

[uginbgood]

found bug in 0.56.1 with Newstations. Без имени, 1980-01-01#1.png. previously never had a problem with that grf. grfs.png

Where did you get that version of NewStations?

I've been using this grf for a long time, and i have two different versions - for OTTD and for TTD patch. Its uses different palettes.
Searching for different old grfs can take a lot of time and effort cause its not available on bananas.
I've spent a lot of time to collecting them, since 2014, when I got hooked on OTTD

[uginbgood]

First of all, thanks for the patch pack, great work.

One small proposal: Would it be possible to add a statistic regarding the amount a cargo that a train transports?
Something like the already existing "Lifetime profits" – it would be optimal to have in parallel the “Lifetime amount of transported cargo” and then this value divided by the age of the train.
The background of this proposal is that in case of complex, multi-step “Transfer”-Scenarios it would be great to be able to monitor the transport capability of the individual steps.

this seems like a good idea and could help compare the efficiency of different transport routes

[OzTrans]

JGR v0.56.0 vs OpenTTD v1.11.0

What has happened to Rail Station Properties 0x11 (Pylons), 0x14 (Wires) and 0x15 (NoTrack) ? They no longer work in JGR-PP, they are simply ignored !

I have set tile types 0x04 and 0x06 to No-Pylons=0x0F, No-Wires=0xF0 and No-Track=0xF0 (tile types 0x00 and 0x02 are all pylons, wires and tracks). CB 0x24 sets the tile types, 0x06 for the tower and 0x00 for the track.

Station tiles set to tile type 0x06 will show pylons and wires and trains are entering happily. This should not happen. In OpenTTD this all works fine.

The coal loading station works both in JGR and OpenTTD and are the same; the coaling tower is a No-Track tile.

Coal Loader.png (27.55 KiB) Viewed 55509 times

Coal Loader [JGR].png (49.34 KiB) Viewed 55509 times

Coal Loader [OpenTTD].png (57.44 KiB) Viewed 55509 times

[JGR]

JGR v0.56.0 vs OpenTTD v1.11.0

What has happened to Rail Station Properties 0x11 (Pylons), 0x14 (Wires) and 0x15 (NoTrack) ? They no longer work in JGR-PP, they are simply ignored !

I have set tile types 0x04 and 0x06 to No-Pylons=0x0F, No-Wires=0xF0 and No-Track=0xF0 (tile types 0x00 and 0x02 are all pylons, wires and tracks). CB 0x24 sets the tile types, 0x06 for the tower and 0x00 for the track.

Station tiles set to tile type 0x06 will show pylons and wires and trains are entering happily. This should not happen. In OpenTTD this all works fine.

The coal loading station works both in JGR and OpenTTD and are the same; the coaling tower is a No-Track tile.


Coal Loader.png

Coal Loader [JGR].png

Coal Loader [OpenTTD].png

It may be worth comparing with a newer version of vanilla (13.4 or a current nightly).

This may be related to the bug discussed earlier on this page, if that's the case it'll be fixed in the next release.

If not I'll probably need a GRF which shows the problem to work out what the cause is.

[OzTrans]

... Issue with rail stations ...

It may be worth comparing with a newer version of vanilla (13.4 or a current nightly).

I tried OpenTTD v13.4, there are no issues at all.

This may be related to the bug discussed earlier on this page, if that's the case it'll be fixed in the next release.

I don't think, my issue has anything to do with the issue mentioned above. I do have that problem too with my old Canadian Stations, as they were coded to be compatible with TTDPatch and in those days, we only had 3 rail types (anything other than normal rail now shows these symptoms too). That is why I have decided to recode everything from scratch. So far that works fine.

All stations display correctly at all times, including being snow-aware, having fences or depending on neighbouring tiles.

Every station, that sets 0x11, 0x14 and 0x15 to the same value for all bits, and where CB24 returns the one tile type only, works fine. But things fail when those bits are not set to the same and CB24 returns differing tile types depending on var 0x10 (i.e. 0x41 at construction).

If not I'll probably need a GRF which shows the problem to work out what the cause is.

Now, I have put together a Test GRF (It'll be in the mail shortly anyway), but the results are mixed. You may have a look at it anyway, otherwise things have to wait.

[Domo_77]

Hello, i have question if it is decouple in this path?

[BubuSK]

Hello,

I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.

Bubu

[JGR]

Hello,

I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.

Bubu

If you could post the savegame causing the issue I'll take a look at it.

[OzTrans]

* Fix high-speed trains reversing at waypoints/behind signals failing to stop and reverse in some cases.
* Fix incorrect graphics/behaviour and blocked/wire/pylon states with certain rail station NewGRFs.

Wonderful ...

Thanks for fixing it. All works fine now.

[BubuSK]

Hello,

I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.

Bubu

If you could post the savegame causing the issue I'll take a look at it.

Thank you JGR!

My savegame has 27MiB which is larger than max. filesize allowed here for attachments. I am therefore sharing link to the Google drive with the savegame file:
https://drive.google.com/file/d/135meP8 ... sp=sharing

Let me know if I can help further with testing

p.s. Happy New Year to everyone in the community!

[JGR]

Hello,

I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.

Bubu

If you could post the savegame causing the issue I'll take a look at it.

Thank you JGR!

My savegame has 27MiB which is larger than max. filesize allowed here for attachments. I am therefore sharing link to the Google drive with the savegame file:
https://drive.google.com/file/d/135meP8 ... sp=sharing

Let me know if I can help further with testing

p.s. Happy New Year to everyone in the community!

This seems to be caused by the industry set defining nonsense name suffixes for new stations placed near some industry types.
I'll update the string handling in the next release so that a placeholder value is displayed instead of triggering a fatal error.

[Argus]

Which industrial set is this? I'd rather pay attention to the update.