YAPF - Testers needed!

gkirilov · Post by **gkirilov** » 28 May 2006 12:34

I think KUDr will continue working on PBS. If I am wrong, please correct me.

Wolf01 · Post by **Wolf01** » 28 May 2006 12:38

i hope that

PBS is a great thing (also YAPF is a very great thing)

Frostregen · Post by **Frostregen** » 28 May 2006 18:10

Nobody reported compilation errors except Watcom and VC6 (that are no longer supported due to very bad C++ support).

Guess I have to switch to something else now.
Will be Eclipse + CDT + Cygwin now.
Working fine so far

Sacro · Post by **Sacro** » 28 May 2006 21:49

How do you get eclipse to work with the makefile? or dont you bother?

Frostregen · Post by **Frostregen** » 28 May 2006 23:41

What do you mean by "get eclipse to work with the makefile"?
I don't need to change anything in the makefile.
Just remove the default target "all" in eclipse, and it compiles fine.
(for a full rebuild you have to manually clean and build, but thats not a problem)

White Rabbit · Post by **White Rabbit** » 29 May 2006 10:08

I think something YAPF-related crashed Brianetta's nightly server (I don't have the crash report, I just timed out, because he was hosting). What happened was that two of my trains crashed, and moments afterwards, the server went down. Attached is the savegame in .tmp format.

KUDr · Post by **KUDr** » 29 May 2006 15:13

Thanks for that savegame. But unfortunatelly it works well for me (no asserts, crashes or any bad sign). The same as game provided by Brianetta yesterday.

But finally I was lucky and got savegame + exact case description how to reproduce it from Celestar. So it should be fixed at r5013 (also in today's nightly).

If the problem persists call your administrator. If you are your own admin then post new report (but please reproducible one) into flyspray or here.

Thanks, KUDr

gkirilov · Post by **gkirilov** » 30 May 2006 21:04

KUDr, can you write the options in the patches screen that should be on (or off) in order to use the YAPF.

KUDr · Post by **KUDr** » 30 May 2006 22:20

gkirilov: I don't understand what exactly you mean.

There are only three on/off switches for YAPF for three transport types (ships, RVs and trains). The first one (ships) has default value off, the other two are on by default.

Thief^ · Post by **Thief^** » 31 May 2006 01:17

I think gkirilov was asking whether NPF still needed to be on for YAPF, and what happens if NPF isn't on and YAPF is or NPF is and YAPF isn't.

Smoky555 · Post by **Smoky555** » 31 May 2006 05:12

SVN 5006, 5054, compiled in cygwin

When i enable YAPF for trains they didn't want to go to depot for servicing.

Attached save is for 5054.

KUDr · Post by **KUDr** » 31 May 2006 06:53

Fixed:

[08:52:00] <CIA-3> KUDr * r5057 /trunk/yapf/yapf_rail.cpp: -Fix: [YAPF] trains can't find depot for servicing (thanks Smoky555)

gkirilov · Post by **gkirilov** » 31 May 2006 06:58

Thief^ wrote:I think gkirilov was asking whether NPF still needed to be on for YAPF, and what happens if NPF isn't on and YAPF is or NPF is and YAPF isn't.

Yes, something like this.
In other words. What should be on/off in order to use YAPF, NPF, original PF.

Smoky555 · Post by **Smoky555** » 31 May 2006 07:14

KUDr wrote:Fixed:

[08:52:00] <CIA-3> KUDr * r5057 /trunk/yapf/yapf_rail.cpp: -Fix: [YAPF] trains can't find depot for servicing (thanks Smoky555)

thanks

KUDr · Post by **KUDr** » 31 May 2006 21:35

gkirilov: aha, sorry for misunderstanding

1) NPF overrides NTP
2) YAPF overrides both NTP and NPF so it doesn't matter if you have switched on the NPF or not
3) Forbid 90-deg works for NPF and YAPF (not for NTP). Again, it doesn't matter if you have NPF enabled or not.

I will need to make GUI texts more clear i guess

hertogjan · Post by **hertogjan** » 02 Jun 2006 21:28

Is it true that YAPF tries to send my road vehicles to a competitor's depot (and vice versa)?
Answer: Yes, it even succeeds in getting my buses into someone else's depot.

This may be a bug caused by YAPF, since it doesn't happen when YAPF for road vehicles is disabled.
The problem may also be there for ships, although I haven't tested it (since the AI never builds ships). Someone may have to take a look at it, though.

KUDr · Post by **KUDr** » 03 Jun 2006 08:23

hertogjan:

5080-Fix: RVs can enter other player's depot or roadstop (introduced by YAPF related change of GetTileTrackStatus() - r4419)

did you mean that? It was my bug, sorry. But should be OK now.

hertogjan · Post by **hertogjan** » 03 Jun 2006 17:43

Yes, that seems to be the right description of what I have seen.

Smoky555 · Post by **Smoky555** » 05 Jun 2006 17:25

Hi

I found a ... bug or ....

Just simulate this situation: 3 stations (A, B and C), 1 depot and 3 trains.
Two of them has this orders: Go to station A -> Goto station B
One of them has this order: Goto station B -> Goto station A.
No one has in orders station C, but when i start the game with YAPF enabled, 1 train going to station A, second going to station B and the last train going to station C (!!!) - WHY ???.
When i disable YAPF, no one going to station C (it's normal).

OpenTTD rev 5113.

Situation is like on the picture.

XeryusTC · Post by **XeryusTC** » 05 Jun 2006 18:22

That is probably because YAPF thinks that the ways to Station A/B are dead ends and the train can only pick Station C.

Transport Tycoon Forums

YAPF - Testers needed!

Who is online