Aircraft queueing & planespeed

Hazelrah · Post by **Hazelrah** » 20 Jul 2006 04:21

CobraA1,

I hope you've just hit a busy spell and haven't given up on this patch's inclusion into the MiniIN!

I just wanted to let you know that I've added your patch on the MiniIN wiki page under the " Likely to be added if updated by author" section. Due to richk67's posts in this topic, I'm pretty sure that's the case.

Good luck!

-Hazelrah

CobraA1 · Post by **CobraA1** » 25 Jul 2006 02:58

I dunno what's wrong with those helicopters

. I just can't think of what could cause that.

Other than that, the patch should work fine.

AlexH. · Post by **AlexH.** » 29 Jul 2006 00:44

I just wanted to let you know that I've added your patch on the MiniIN wiki page under the " Likely to be added if updated by author" section.

It looks that there it already added, with note saying: "updated to 4000+. awaiting confirmation it is current". I have removed that entry, leaving yours.

CobraA1 · Post by **CobraA1** » 30 Jul 2006 17:51

It's updated now.

AlexH. · Post by **AlexH.** » 31 Jul 2006 23:22

Works perfectly!
Very nice is regulation of plane speed, from default to realistic. I didn't found also any errors while using helicopters and helipads. Unfortunately patch corrupts while trying to update MiniIN to latest build (5688). Under r5656 is ok.

CobraA1 · Post by **CobraA1** » 01 Aug 2006 13:18

Umm, I didn't fix the helicopter stuff, as I never figured what the exact problem was. Perhaps it was not my patch? Not sure.

The latest conflict is due to them lagging behind the trunk, which had a conflict to resolve. I will release an update soon.

Edit: I resolved the conflicts and uploaded a new version of the patch for MiniIN.

AlexH. · Post by **AlexH.** » 01 Aug 2006 14:41

No? My helicopters flew without problems, maybe something will happen later... hope no

richk67 · Post by **richk67** » 01 Aug 2006 14:48

OK I'll take another look, but maybe not for a couple of days. (busy)

CobraA1: can you post a link to your patch, or the full MiniIN patch in the MiniIN TODO topic in Suggestions? Just helps keep me organised

AlexH. · Post by **AlexH.** » 01 Aug 2006 15:43

Oops - there is too many options in Vehicles panel and buttons for your patch are unclickable, the only way to modify coeff is to edit openttd.cfg file

CobraA1 · Post by **CobraA1** » 02 Aug 2006 01:35

Oh dear, it appears as time goes on, the number of troubles with my patch only increases

. I don't have much time, but I'll see what I can do.

AlexH. · Post by **AlexH.** » 03 Aug 2006 17:01

There is another issue - when on a long route plane breaks down, it immediately blocks whole airport, as it comes in front of landing queue. Maybe enable moving broken planes in front of the queue only when they circle above airport?

Aracirion · Post by **Aracirion** » 03 Aug 2006 17:29

couldn't broken-down planes be directed to the nearest airport, instead of finishing their whole journey half-speed? That would be more realistic as well as more convenient ...

CobraA1 · Post by **CobraA1** » 04 Aug 2006 03:46

ok, fixed the saveload stuff, pointed the wiki to the correct place to find the MiniIN patch, added a link to the thread, fixed the size of the patches box, added to the TODO thread after some searching, etc etc, so hope things are OK now.

Aracirion: Personally, I leave "Give priority to broken aircraft" (in the stations section of the patches) turned off. Personally, I don't use it, and it's mostly there for people who like it. Aircraft simply break down too predictably and too often for this to really be realistic.

Also, I'm not sure if there's any code in place to locate the nearest airport? If not, then writing such a thing would be non-trivial, and I don't really have much time for large code changes right now.

DaleStan · Post by **DaleStan** » 04 Aug 2006 04:08

CobraA1 wrote:Also, I'm not sure if there's any code in place to locate the nearest airport? If not, then writing such a thing would be non-trivial, and I don't really have much time for large code changes right now.

It seems to me like it should be pretty easy:
(In something that vaguely resembles C)

Code: Select all

int mindist=INT_MAX,curdist
stationID closest=NO_STATION
foreach(station st in stations){
    if(!has_airport(st))continue;
    curdist=/*Insert distance function here. I might use Manhattan distance (x+y) since it's notably faster than Euclidean, and because TTD uses (AIUI) 3-3-4 "right" triangles*/;
    if(curdist<mindist){
        closest=GetStationID(st);
        mindist=curdist;
    }
}

CobraA1 · Post by **CobraA1** » 04 Aug 2006 05:54

ok, well, here's what really has to happen:

-The broken aircraft has to be detected (very easy, it's just a flag)
-The nearest hangar has to be found that supports the condition that the airport the hangar is at must accept aircraft (not just helicopters)
-The aircraft's current command must be changed to head to the hangar
-The aircraft must be taken out of any queues it belongs to

DaleStan · Post by **DaleStan** » 04 Aug 2006 07:47

CobraA1 wrote:-The nearest hangar

If you want to be that picky, what you're interested in is, for planes, distance from plane to runway start to runway end to hangar, and, for choppers, distance from chopper to landing point to hangar. But I figure that the XY of the station sign ought to be a close enough approximation.

CobraA1 wrote:has to be found that supports the condition that the airport the hangar is at must accept aircraft (not just helicopters)

So you check the airport type after checking whether the station has an airport. I'm not at all familiar with that part of the code, but I am under the impression that this should be relatively simple; an if cascade on the is_chopper() and is_large() results, and nested in there, an if(airport_type() <has appropriate value>).

Oh, you have to check ownership too.

CobraA1 wrote:-The aircraft's current command must be changed to head to the hangar

Hmm... No clue here. It doesn't seem like it ought to be that hard, but I've got no conclusion to "I know it's already implemented because ..."

CobraA1 wrote:-The aircraft must be taken out of any queues it belongs to

I know you already have code to do this, as you have to do that anyway whenever the user changes the plane's orders.

But yes, I did substantially oversimplify it.

CobraA1 · Post by **CobraA1** » 04 Aug 2006 11:06

If you want to be that picky

I realized I have to be - after all, if the plane has broken down, it needs to be fixed, and the place to fix a plane is at a hangar.

I'll take a look, I guess it's doable.

Aracirion · Post by **Aracirion** » 04 Aug 2006 11:48

CobraA1 wrote:I'll take a look, I guess it's doable.

oh wow that would be cool .. .I didnt want to give you a lot of work

just wanted to make a suggestion I had thought of sometime ... there was plenty of time to think about it while watching my broken-down planes limp to their original destination .....

CobraA1 · Post by **CobraA1** » 04 Aug 2006 13:35

Turns out that's the easy part - there's built in functions for that kind of stuff.

The most difficult task seems to be sending the aircraft to the new depot - the command is stuck into the GUI interface, and not very accessible from code.

Luckz · Post by **Luckz** » 04 Aug 2006 14:42

DaleStan wrote:
CobraA1 wrote:has to be found that supports the condition that the airport the hangar is at must accept aircraft (not just helicopters)
So you check the airport type after checking whether the station has an airport. I'm not at all familiar with that part of the code, but I am under the impression that this should be relatively simple; an if cascade on the is_chopper() and is_large() results, and nested in there, an if(airport_type() <has appropriate value>).

Oh, you have to check ownership too.

..and keep in mind that you might be allowed to use stations you don't own.

Transport Tycoon Forums

Aircraft queueing & planespeed

Who is online