Page 11 of 14

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 22 Jun 2012 22:56
by eastpath
I got your great patch compiled and running on a Raspberry Pi http://www.tt-forums.net/viewtopic.php? ... 7#p1029917

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 21 Jul 2012 17:02
by Streckenläufer
Hello,
I've added the patch manually to the r24418 and Compiled get an error in the rail_cmd.cpp, has anyone experience with this error:

This patch would be very interesting for the subway.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 25 Jul 2012 15:57
by Streckenläufer
get the part at r24434 simply not up and running shows ever, and Draw bool error at compile time. Does this experience. I suspect that a double bool = variable is present.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 25 Jul 2012 16:56
by Alberth
The error means that you use a "cost" variable, which does not exist.

Quite likely, the variable existed in the program when the patch was written, and that part of the code has been changed between then and now. SVN can tell you what changed in the file. You have to change the patch as well.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 25 Jul 2012 20:48
by Streckenläufer
Thanks, I'll continue trying.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 25 Jul 2012 22:44
by FLHerne
Because the patch is (while convenient - I always play with it) something of a hack, and has some irritating bugs. Trunk would need at least a more polished version of the current idea, or ideally a way to actually place signals in tunnels, rather than simulate them in a way that causes various problems.

EDIT: I believe one of the posts above may have been edited, this one no longer makes any sense :? .

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 27 Jul 2012 18:16
by Streckenläufer
FLHerne, I totally agree!

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 03 Sep 2012 10:03
by wjhulzebosch
I had an idea about signals in tunnels etc. and i was wondering if it could be done.

Instead of rewriting OTTD entirely to allow for signals in tunnels and on bridges, couldn't we write something that lets the trains decide wether to go on or to stop? We have path signals; they see if a block until the next signal is free. Couldn't we just change this in "check if the next tile is free"? That way, we wouldn't even need signals anymore, maybe just to create one-way tracks...

Maybe a stupid idea, but if this could be done, a whole lot of problems would be solved and i would need a lot less signals :)

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 03 Sep 2012 10:36
by Eddi
what you describe is the behaviour of road vehicles.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 03 Sep 2012 15:06
by kamnet
wjhulzebosch wrote:I had an idea about signals in tunnels etc. and i was wondering if it could be done.

Instead of rewriting OTTD entirely to allow for signals in tunnels and on bridges, couldn't we write something that lets the trains decide wether to go on or to stop? We have path signals; they see if a block until the next signal is free. Couldn't we just change this in "check if the next tile is free"? That way, we wouldn't even need signals anymore, maybe just to create one-way tracks...

Maybe a stupid idea, but if this could be done, a whole lot of problems would be solved and i would need a lot less signals :)
While in-cab signalling and automatic train control systems have existed since the early 1900s, there is no unified standard, nor do all trains companies use them even today. Track-side signalling is still required on the majority of railroad systems.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 04 Sep 2012 01:02
by cmoiromain
I don't think he wanted to know if it was possible in real life (ie. realistic), but rather in the game.

Indeed, it is possible, and probably rather simple (since, as Eddi just stated, it is pretty much how road vehicles work). However, where is the fun in that ? Plus, if you had to change all tracks to one-way tracks, there would probably be some problems at junctions, and I don't know how you would display it in the game.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 13 Sep 2012 12:31
by Streckenläufer
Hello,

I tried to insert (by hand) in the signaltunnel_V3.02_r24031.patch to r24521.
Get an error message when you compile but as indicated in the picture.

Can someone do something with it and tell me which this "signale_side" is linked?

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 13 Sep 2012 13:25
by Eddi
as far as i can see, it has been renamed to "train_signal_side" (see src/table/settings.ini)

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 13 Sep 2012 13:35
by Streckenläufer
WOW Eddi, if I would not have you, it works, thank you

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 14 Sep 2012 14:27
by Quast65
Would it be possible to post that new version?
Maybe donate it to the original author via PM so (s)he can doublecheck it and then release it?
Because I really like to use this patch in a newer version of OpenTTD (everything newer from r24402) as that has some bugfixes for some GRF's I made.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 15 Sep 2012 09:59
by Streckenläufer
Hello

I have entered all patches by hand, usually vote no longer the line numbers or variables have changed (see above for Eddi)

Now, I'm going the signaltunnel.patch in the r24524 a bank setting. Problems really only the language file (String1) (string2) if I this comment from the english.txt remove and compiling then it goes again, otherwise I get a language error as often described.
I also get error when I insert the text in the german.txt. Here, the STR_ STRINGS cause me problems. Is a lot of Fummel work.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 18 Sep 2012 14:08
by Streckenläufer
Hello

tried the signaltunnel_V3.02_r24031.patch in the r24530M to insert.
Works so far, very good, get when opening from OpenTTD this message in the main window (see annex 1)

When I click Advanced settings > design > signals click, is a crash with the error section 2 (see annex 2).

Maybe someone on this error has a tip! what strings could be meant?

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 18 Sep 2012 20:00
by Supercheese
The extra descriptions in the advanced settings window (that appear at the bottom when clicking a setting to highlight it) were added in a revision after the patch, if I'm not mistaken. You'll probably need to add the description if it's missing from the advanced setting(s) introduced by this patch.

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 19 Sep 2012 21:26
by Streckenläufer
Hello
It was as always the strings in the German language file and a + in the settings.gui, running again in the r24532

Re: Signals in tunnels and on bridges V3.02 r24031

Posted: 20 Sep 2012 13:23
by FaantBoy501
Hello All,

I also have been trying to apply this Signal in Tunnel patch, but with little succes. Am not an expert at this, sadly, but I managed to use TortoiseSVN 1.7.9 and OpenTTD Trunk R24534.
When I try to apply the patch itself, it gives me around 5 faulty messages. But I really don't have a clue how to solve this. Maybe someone can help me out with this. Thx in advance.