Red*Stars modern train station set [beta released]

[Nite Owl]

I think I have solved the problem. Following YukonRob's post I downloaded and applied r22254. Low and behold I was able to build the Hannover Messe Laatzen station correctly. I then went to the latest edition of trunk that I have been using, r22317 as stated in my original post about this problem, and I could NOT build this station properly. Obviously something had changed between these two releases. After a quick scan of the changelog between the two I ran across the following:

r22286 -Fix: [NewGRF] the c and p parts of station vars 40, 41 and 49 were incorrect for large stations.

This is the only change to the station NewGrf code I could find between these two releases. I must therefore submit that this is the cause of my inability to build this station properly within the latest versions of the nightlies. Since the correction to the game code is the priority I can only await a recoding of this NewGrf to this new standard in order to be able to use this station. I will, of course, wait patiently. XeryusTC are you out there?

[YukonRob]

As deduced - just updated to r22323 and the station is a no go.

[Nite Owl]

Thank you for the confirmation. It is good to know that I am not completely crazy - partially perhaps, but not completely.

[Sensation Lover]

Just downloaded and tried (successfully) in r22254.

FYI - for those of you thinking he has not followed instructions - the light green area IS part of the station, so he has a few 5x5 stations. It will also not let you drag and drop the wrong size.

Yes, i noticed 2 stations that seem to be 5*5, but i just tried again to d&d that station in 5*5 and i was only succesful, i don't understand how he did it to not be succesfull

[Nite Owl]

It all depends on the version of OpenTTD you are running as changes were made in a somewhat recent nightly that affect the way this NewGrf is currently coded. Please read the posts on this page directly preceding your last post for a more complete explanation.

[jakebomey2]

A and B are same looks like
B and C the windows are narrower
A and C same as B and C :/
but its a mericle

[XeryusTC]

XeryusTC are you out there?

I have currently lost all my interest in coding, and trying to fix this would at least take a day of installing stuff and trying to wrap my head around the code so don't expect it to be fixed by me soon (the weather out here is so nice atm ). The code is available at the #openttdcoop devzone though so you could take a look at it yourself if you have any experience with it.

[Nite Owl]

Completely understandable. One must have the knowledge and talent and the desire to take on such projects simply for the sake of doing so. I, unfortunately, may have the desire but lack the knowledge and talent. No matter how many times I have tried to wrap my head and hands around coding and pixel art the result has always been a disaster. We shall wait and see if anyone else is willing to take up the gauntlet. Thank you XeryusTC for getting this project to this point.

[Nite Owl]

Please forgive the double post but I wanted to be sure that this was seen by all concerned. The following revision to the OpenTTD source code was made by frosch:

r22472 -Fix: When a NewGRF assigned station properties 09 and/or 0A multiple times, the previously allocated sprite layouts were not freed.

I tested this out as I thought it might have an application to the problem I was having with the Hannover Messe Laatzen station as documented in the series of posts preceding this one. I am pleased to report that this station is now, once again, able to be built after applying the appropriate nightly release. Thank you frosch.

[planetmaker]

XeryusTC are you out there?

I have currently lost all my interest in coding, and trying to fix this would at least take a day of installing stuff and trying to wrap my head around the code so don't expect it to be fixed by me soon (the weather out here is so nice atm ). The code is available at the #openttdcoop devzone though so you could take a look at it yourself if you have any experience with it.

Well, you made clear in your "license" that exactly that, others fixing the issues you left behind, is NOT in your interest. Given the spirit of the devzone which hosts _free_ and _open_ source (and not proprietary stuff), that should be re-considered...

Currently everyone who wants to 'fix' it, will have to forget about what you wrote and write a new station set from scratch.

[azett]

Hi, getting back to this older thread: These stations look awesome!
But having the grf installed on TTDPatch r2366 (latest nightly), it will come up with an error about an invalid sprite, so i can't use the grf

1.png (9.17 KiB) Viewed 6314 times

2.png (16.19 KiB) Viewed 6314 times

grfdebug.txt says:

Code: Select all

# Modern train station set
newgrf/MODERN_SET.GRF
# 58534D00
# Based on various real life stations    Drawn by Red*Star. Coded by XeryusTC
# Faulty A:80 F:00 MD5:6F4C28B41F5127046DED0320D0BE533B
# ”Datei "newgrf/MODERN_SET.GRF" hat ungültiges Sprite #942 (code 4/6).

Where's my mistake and how to fix it?
Thx a lot!

[michael blunck]

Hi, getting back to this older thread: These stations look awesome!
But having the grf installed on TTDPatch r2366 (latest nightly), it will come up with an error about an invalid sprite
[...]
Where's my mistake and how to fix it?

This newGRF seems to be faulty. It has been discussed on the German TTD-forums recently.

regards
Michael

[azett]

Oh, I see...thanks for the info!

[Jacko]

Just a few things:
1. Awesome set!
2. is there any way to get buffers on this set?
3. when i use monorail or maglev the stations go all glitchy

note:
im not asking you to fix it
i was wondering if you knew anything about it...

[bremerjoe]

In regards to second question: I suggest using those from rural or city station NewGRF. They work OK at least for Berlin Hauptbahnhof.

[Morgs]

TBH I rarely use this GRF because I can't build the more complex stations of this set for example the Berlin Hauptbahnhof.

When an updated version is released can a user guide in a PDF be done like the Canadian Stations GRF???

[bremerjoe]

There was a detailed pdf explaining the process for each station. Gotta check where I got it from though. Give me a few minutes...

EDIT: Just found it. Was not a pdf file but a html file that yo can open with any browser. As linked to on the first posting of the topic you will find it here: http://www.tt-forums.net/viewtopic.php?p=908360#p908360

[kamnet]

Well, I dunno how pretty it is, but here's a PDF conversion (2.5 MB)

[trainman1432]

Surprise, surprise. Here is the release! Doing stuff when tipsy is not the most productive I must say so it is possible that I forgot something.

Basicly this is 1.0-beta. Why is it beta you ask? Well, that's simply because large parts of it are untested and might not behave properly. Glitching errors are possible especially on stations with graphics which hang over the tracks so to say.
It is also highly recommended that you take note of the readme file as you might not be able to figure out how to (properly) build all the stations otherwise.

You might want to download this set after the weekend if you have anything planned

could you make a download for the file(.grf) itself?

[kamnet]

could you make a download for the file(.grf) itself?

It's linked to on the first post in the topic.