George's new cargos [aborted] Use ECS instead

[Purno]

Would you draw petrol station?

IIRC Zimmlock drew one.

[Wile E. Coyote]

It'd be great if you'd provide link to it

[Csaboka]

It'd be great if you'd provide link to it

It looks like this:
(The red part is in random color)

The image is from Zimmlock's TTRS site

[George]

George, you'll plan petrol as cargo. Would you draw petrol station? I plan to use petrol too in Serbian rail set, so it'd be great if there'll be available petrol station (2x1 tiles).

I do not plan it - I do it now. If you want, I can post a demo

[Wile E. Coyote]

George: Sure!
Csaboka: it's 1x1 tile, is it possible to replace bank with it (2x1 tile)?

[George]

George: Sure!
Csaboka: it's 1x1 tile, is it possible to replace bank with it (2x1 tile)?

I code petrol stations as buildings

[Wile E. Coyote]

Anyway, you could post it (and, of course, explain what buildings you replaced ) I'm still messed up with new cargos and industries

[Csaboka]

Wile E. Coyote: You don't have to replace the old industries with the new ones. The new and old types can live peacefully together until the (I think reasonable) limit of 37 industry types is hit. That is, you don't have to kick out the bank to have petrol stations.

[George]

I've got some problems with coding again. this code crashaes the game, but I can't understand why

Code: Select all

// - Hotel Pribaltiskaya 
// Should appear only at least in 1 and max in 3 cities after 1975
// The remove cost should be about 12.5-25% of the bank remove cost 
// Should be rebuild on the map if the last one is demolished
// The grey-brown variant should be build the first
// There should not be two same variants on the map
// Should not appear in desert
// Should appear near the water (if possible)
   92 * 6	 07 83 01 03 05 13
// - Grey version
   94 * 5	 0A 01 07 3B 11
   95 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 386 88 09 31 64 -31 0
   96 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 466 88 09 92 64 -31 -76
   97 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 2 200 09 31 64 -31 0
   98 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 82 200 09 103 32 1 -88
   99 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 130 200 09 31 64 -31 0
  100 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 210 200 09 103 32 -31 -88
  101 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 258 200 09 31 64 -31 0
// - Brown version
  103 * 5	 0A 01 07 3B 11
  104 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 370 200 09 31 64 -31 0
  105 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 450 200 09 92 64 -31 -76
  106 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw00.PCX 530 200 09 31 64 -31 0
  107 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 2 8 09 103 32 1 -88
  108 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 50 8 09 31 64 -31 0
  109 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 130 8 09 103 32 -31 -88
  110 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 178 8 09 31 64 -31 0
// - Brown-grey version
// (North) Accepts Tourists, passengers and mail
  113 * 41	 00 07 0F 01 00 08 28 09 10 0A 3A FF 0B 60 0C 40 0D 08 0E 03 0F 04 10 20 03 11 F0 13 13 F8 14 01
	         18 FF 19 02 1E 1A 00 02 FF
// (East)  Accepts Tourists, passengers and beer
  115 * 41	 00 07 0F 01 01 08 29 09 10 0A 3A FF 0B 00 0C 20 0D 08 0E 01 0F 04 10 20 03 11 F0 13 13 F8 14 01
	         18 FF 19 02 1E 1A 00 12 FF
// (West)  Accepts Tourists, passengers and food
  117 * 41	 00 07 0F 01 02 08 2A 09 10 0A 3A FF 0B 00 0C 20 0D 08 0E 01 0F 04 10 20 03 11 F0 13 13 F8 14 01
	         18 FF 19 02 1E 1A 00 0C FF
// (South)  Accepts Goods, passengers and mail
  119 * 41	 00 07 0F 01 03 08 2B 09 10 0A 3A FF 0B 00 0C 10 0D 08 0E 04 0F 04 10 20 03 11 F0 13 13 F8 14 01
	         18 FF 19 02 1E 05 00 02 FF
  120 * 4	 01 07 07 01
  121 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 418 8 09 31 64 -31 0
  122 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 498 8 09 92 64 -31 -76
  123 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 2 136 09 31 64 -31 0
  124 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 82 136 09 103 32 1 -88
  125 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 130 136 09 31 64 -31 0
  126 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 210 136 09 103 32 -31 -88
  127 F:\GAMES\TTD-WIN\GRF\pl\SPRITES\NewCargosPetrolTouristsw01.PCX 258 136 09 31 64 -31 0
  128 * 17	 02 07 00 00 00 00 00 80 01 00 00 80 00 00 10 10 67
  129 * 17	 02 07 01 00 02 00 00 80 03 00 00 80 00 00 10 10 67
  130 * 17	 02 07 02 00 04 00 00 80 05 00 00 80 00 00 10 10 67
  131 * 17	 02 07 03 00 06 40 00 80 06 00 00 80 00 00 10 10 67
  132 * 14	 02 07 10 81 0C 00 FF 01 00 FF 17 17 00 00
  133 * 14	 02 07 20 81 0C 00 FF 01 01 FF 17 17 00 00
  134 * 14	 02 07 30 81 44 00 FF 01 20 00 00 00 10 00
  135 * 14	 02 07 11 81 0C 00 FF 01 00 FF 17 17 01 00
  136 * 14	 02 07 21 81 0C 00 FF 01 01 FF 17 17 01 00
  137 * 14	 02 07 31 81 44 00 FF 01 21 00 00 00 11 00
  138 * 14	 02 07 12 81 0C 00 FF 01 00 FF 17 17 02 00
  139 * 14	 02 07 22 81 0C 00 FF 01 01 FF 17 17 02 00
  140 * 14	 02 07 32 81 44 00 FF 01 22 00 00 00 12 00
  141 * 14	 02 07 13 81 0C 00 FF 01 00 FF 17 17 03 00
  142 * 14	 02 07 23 81 0C 00 FF 01 01 FF 17 17 03 00
  143 * 14	 02 07 33 81 44 00 FF 01 23 00 00 00 13 00
  144 * 7	 03 07 01 00 00 30 00
  145 * 7	 03 07 01 01 00 31 00
  146 * 7	 03 07 01 02 00 32 00
  147 * 7	 03 07 01 03 00 33 00
  148 * 28	 04 07 9F 01 00 C9 48 6F 74 65 6C 20 22 50 72 69 62 61 6C 74 69 73 6B 61 79 61 22 00
  149 * 28	 04 07 9F 01 01 C9 48 6F 74 65 6C 20 22 50 72 69 62 61 6C 74 69 73 6B 61 79 61 22 00
  150 * 28	 04 07 9F 01 02 C9 48 6F 74 65 6C 20 22 50 72 69 62 61 6C 74 69 73 6B 61 79 61 22 00
  151 * 28	 04 07 9F 01 03 C9 48 6F 74 65 6C 20 22 50 72 69 62 61 6C 74 69 73 6B 61 79 61 22 00

[Patchman]

Can you post the crash log?

[Wile E. Coyote]

Wile E. Coyote: You don't have to replace the old industries with the new ones. The new and old types can live peacefully together until the (I think reasonable) limit of 37 industry types is hit. That is, you don't have to kick out the bank to have petrol stations.

It's OK but bank in tropical climate accepts diamonds, and I want to eliminate diamond mines and replace them with nickel ore mines (nickel ore could be transported to factories). Banks could stay, but in that case they could produce valuables, and than valuables will be transported within banks (like in temperate climate). Also, oil refineries would produce petrol (transported to petrol stations) and rubber (transported to factories), and rubber plantation are also needed to eliminate. All these changes are needed in tropical climate only. I hope it's all possible.

[George]

Can you post the crash log?

yes

[Patchman]

Hmm, that crash is in TTD code, and in a place I'm not familiar with. I'll have to let Csaba look into it.

[Csaboka]

Now this is really strange. It crashes while trying to draw a snowy tree, but there's no such tree type...

I haven't touched any tree drawing code, so it must be some other error manifesting here. I'd really like to have your GRF plus config to reproduce this.

[edit] Oh, I just noticed there's an error in your GRF, so try fixing that before sending me your config: Additional tiles must have prop 09 as zero, but you have them as 10h. Only the north tile should have prop 09 as 10h, the other tiles should have it as 00h.

[George]

Now this is really strange. It crashes while trying to draw a snowy tree, but there's no such tree type...
I haven't touched any tree drawing code, so it must be some other error manifesting here. I'd really like to have your GRF plus config to reproduce this.

the grf is several posts above. I'll post other files in the evening
Could you have a look into the nfo part for the hotel?

[Csaboka]

Please read my edit

[George]

Please read my edit

Now I got this and a crash a bit later

Code: Select all

TTD V0019E000 Crash Log by TTDPatch 2.0.1 alpha 56 (Windows)

Exception C0000005 at 001B:0055C624

EAX       EBX       ECX       EDX
00000720  000008B0  03450D30  00000408

ESI       EDI       ESP       EBP
000006AD  0043649A  0006A710  00430000

DS        ES        FS        GS        SS        Flags
0023      0023      0038      0000      0023      00010202
FFFFFFFF  FFFFFFFF  00000FFF  ########  FFFFFFFF (Segment limits)
00CFF300  00CFF300  0040F300  ########  00CFF300 (Access rights)

Bytes at DS:EIP
8B 1E 66 83 C3 03 66 03 07 66 03 4F 02 66 BF 05

Stack Dump:
000006AD  0043649A  00000408  03450D30  00000720  0055F1A3  44080000  00000006
0D300004  07200006  0006F950  06C00CD0  0056E358  030A8A96  0006A754  0CD006C0
0000F108  00000522  0006A764  0CE006B0  0000AB08  000014FF  0006A774  0CF006A0
01070008  00000F8D  0006A784  0D000690  0000A708  00000F8D  0006A794  0D100680

Handler Stack Dump (at 0023:0006A4C0):
00004002  00000000  3FFF8000  00000000  00000000  00000038  00000023  00000023
0043649A  000006AD  000008B0  00000408  03450D30  00000720  00430000  0055C624
0000001B  00010202  0006A710  00000023  4000027F  03150000  5B2622FD  0000001B
5B274400  00000023  00001F80  0000FFFF  BF87C978  00000001  00000001  00000000

Patch flags:
FFB8FFFF  FFFFFFFF  FFFFFFFD  00003FFF  00000000  00000000  000DF2BF  A2000000
0000006E  0000002C  00001000  FFFE003C  005007AD  00B40041  016D0041  76260500
13B14EC4  02580320  13880258  05141024  0A28370A  140A1928  1E145014  141E1450
3C1E1E14  003C5A3F  FFFF0314  F0F0F0F0  1EFF0001  005A010A  50040A1E  02010007
010A2357  0301030A  140A0014  FA1E0401  00000000

[Csaboka]

You forgot posting the GRF itself

[George]

You forgot posting the GRF itself

It is as above, I only changed the bytes you suggested to fix
Have a look at one more screenshot. The hotel affects additional tiles nearby. The roads and TREES are changed! That's why it had snow tree crash. Now it made tropic tree (but no crash)

[George]

This bug made me to think about such a possibility (a suggestion)

1) the building has to check for the roads nearby (as I've asked about water) (it would be nice to have it on per-tile base)
2) the building has to chek for possibility to be build for every tile and a whole building has to be buid if all the tiles can be build (may be it is a reason of the crash, because I check callback 17 for every tile?)
3) the building has to have the possibility to be build only on the special road sides (for exemple, the hotel has to have roads SE,S,SW for the south tile)
4) the building has to change whose roads (add or remove connecting parts to create the illusion that a road continues through the building)

It would be handy for petrol station, hotels, hospitals, fire and police stations and arches (like MB's fake building)