JGR's Patch Pack
Moderator: OpenTTD Developers
Re: JGR's Patch Pack
As Santa is on his way, I want to start a new yearly tradition for me by summing up my wishlist for OpenTTD
In no particular order:
- Multicore Processor Support
- One-way Curves (and maybe also T- and X-Crossings)
- More Than 255 Active GRFs In A Game
- More Than 64 Road/Tram-type Slots (Or A Separate Menu For Eyecandy Roadoverlays)
- No Overhang Penalty For Long (PAX)Trains (Possibly As A Cheat)
- Variable Snowline WITH Snowy Coastlines
- Possibility To Give Objects (Maybe Also Other CC-Aware Structures) A Separate Colorscheme (Like With Vehicles)
- Via A Non-Running Animation, Objects Can Have Different Graphics When Placed Multiple Times On The Same Spot
Currently This "Animation" Randomly Picks A Frame Each Time You Place An Object, It Would Be Nice If It Follows The Sequence Of The Animation.
Merry Christmas!!
In no particular order:
- Multicore Processor Support
- One-way Curves (and maybe also T- and X-Crossings)
- More Than 255 Active GRFs In A Game
- More Than 64 Road/Tram-type Slots (Or A Separate Menu For Eyecandy Roadoverlays)
- No Overhang Penalty For Long (PAX)Trains (Possibly As A Cheat)
- Variable Snowline WITH Snowy Coastlines
- Possibility To Give Objects (Maybe Also Other CC-Aware Structures) A Separate Colorscheme (Like With Vehicles)
- Via A Non-Running Animation, Objects Can Have Different Graphics When Placed Multiple Times On The Same Spot
Currently This "Animation" Randomly Picks A Frame Each Time You Place An Object, It Would Be Nice If It Follows The Sequence Of The Animation.
Merry Christmas!!
Projects: http://www.tt-forums.net/viewtopic.php?f=26&t=57266
Screenshots: http://www.tt-forums.net/viewtopic.php?f=47&t=56959
Scenario of The Netherlands: viewtopic.php?f=60&t=87604
Winner of the following screenshot competitions:
sep 2012, jan 2013, apr 2013, aug 2013, mar 2014, mar 2016, oct 2020
All my work is released under GPL-license (either V2 or V3), if not clearly stated otherwise.
Screenshots: http://www.tt-forums.net/viewtopic.php?f=47&t=56959
Scenario of The Netherlands: viewtopic.php?f=60&t=87604
Winner of the following screenshot competitions:
sep 2012, jan 2013, apr 2013, aug 2013, mar 2014, mar 2016, oct 2020
All my work is released under GPL-license (either V2 or V3), if not clearly stated otherwise.
Re: JGR's Patch Pack
found bug in 0.56.1 with Newstations.
. previously never had a problem with that grf. Re: JGR's Patch Pack
This is a known issue, it will be fixed in the next release.
In the meantime you can type `set_newgrf_optimiser_flags 1` in the console to make it go away.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
- Emperor Jake
- Tycoon
- Posts: 3431
- Joined: 24 Apr 2007 09:37
- Skype: Discord: Emperor Jake #4106
- Location: Not Actually Japan
- Contact:
Re: JGR's Patch Pack
Same place where you get the rest of MB's stuff: http://ttdpatch.de/download.html
Re: JGR's Patch Pack
First of all, thanks for the patch pack, great work.
One small proposal: Would it be possible to add a statistic regarding the amount a cargo that a train transports?
Something like the already existing "Lifetime profits" – it would be optimal to have in parallel the “Lifetime amount of transported cargo” and then this value divided by the age of the train.
The background of this proposal is that in case of complex, multi-step “Transfer”-Scenarios it would be great to be able to monitor the transport capability of the individual steps.
One small proposal: Would it be possible to add a statistic regarding the amount a cargo that a train transports?
Something like the already existing "Lifetime profits" – it would be optimal to have in parallel the “Lifetime amount of transported cargo” and then this value divided by the age of the train.
The background of this proposal is that in case of complex, multi-step “Transfer”-Scenarios it would be great to be able to monitor the transport capability of the individual steps.
Re: JGR's Patch Pack
I've been using this grf for a long time, and i have two different versions - for OTTD and for TTD patch. Its uses different palettes.
Searching for different old grfs can take a lot of time and effort cause its not available on bananas.
I've spent a lot of time to collecting them, since 2014, when I got hooked on OTTD
- Attachments
-
- newstats1.png (14.63 KiB) Viewed 56785 times
-
- newstats2.png (18.16 KiB) Viewed 56785 times
-
- newstats3.png (6.83 KiB) Viewed 56785 times
Re: JGR's Patch Pack
this seems like a good idea and could help compare the efficiency of different transport routesOakman wrote: ↑28 Dec 2023 11:59 First of all, thanks for the patch pack, great work.
One small proposal: Would it be possible to add a statistic regarding the amount a cargo that a train transports?
Something like the already existing "Lifetime profits" – it would be optimal to have in parallel the “Lifetime amount of transported cargo” and then this value divided by the age of the train.
The background of this proposal is that in case of complex, multi-step “Transfer”-Scenarios it would be great to be able to monitor the transport capability of the individual steps.
Re: JGR's Patch Pack
JGR v0.56.0 vs OpenTTD v1.11.0
What has happened to Rail Station Properties 0x11 (Pylons), 0x14 (Wires) and 0x15 (NoTrack) ? They no longer work in JGR-PP, they are simply ignored !
I have set tile types 0x04 and 0x06 to No-Pylons=0x0F, No-Wires=0xF0 and No-Track=0xF0 (tile types 0x00 and 0x02 are all pylons, wires and tracks). CB 0x24 sets the tile types, 0x06 for the tower and 0x00 for the track.
Station tiles set to tile type 0x06 will show pylons and wires and trains are entering happily. This should not happen. In OpenTTD this all works fine.
The coal loading station works both in JGR and OpenTTD and are the same; the coaling tower is a No-Track tile.
What has happened to Rail Station Properties 0x11 (Pylons), 0x14 (Wires) and 0x15 (NoTrack) ? They no longer work in JGR-PP, they are simply ignored !
I have set tile types 0x04 and 0x06 to No-Pylons=0x0F, No-Wires=0xF0 and No-Track=0xF0 (tile types 0x00 and 0x02 are all pylons, wires and tracks). CB 0x24 sets the tile types, 0x06 for the tower and 0x00 for the track.
Station tiles set to tile type 0x06 will show pylons and wires and trains are entering happily. This should not happen. In OpenTTD this all works fine.
The coal loading station works both in JGR and OpenTTD and are the same; the coaling tower is a No-Track tile.
Re: JGR's Patch Pack
It may be worth comparing with a newer version of vanilla (13.4 or a current nightly).OzTrans wrote: ↑28 Dec 2023 22:54 JGR v0.56.0 vs OpenTTD v1.11.0
What has happened to Rail Station Properties 0x11 (Pylons), 0x14 (Wires) and 0x15 (NoTrack) ? They no longer work in JGR-PP, they are simply ignored !
I have set tile types 0x04 and 0x06 to No-Pylons=0x0F, No-Wires=0xF0 and No-Track=0xF0 (tile types 0x00 and 0x02 are all pylons, wires and tracks). CB 0x24 sets the tile types, 0x06 for the tower and 0x00 for the track.
Station tiles set to tile type 0x06 will show pylons and wires and trains are entering happily. This should not happen. In OpenTTD this all works fine.
The coal loading station works both in JGR and OpenTTD and are the same; the coaling tower is a No-Track tile.
Coal Loader.png
Coal Loader [JGR].png
Coal Loader [OpenTTD].png
This may be related to the bug discussed earlier on this page, if that's the case it'll be fixed in the next release.
If not I'll probably need a GRF which shows the problem to work out what the cause is.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
I tried OpenTTD v13.4, there are no issues at all.
I don't think, my issue has anything to do with the issue mentioned above. I do have that problem too with my old Canadian Stations, as they were coded to be compatible with TTDPatch and in those days, we only had 3 rail types (anything other than normal rail now shows these symptoms too). That is why I have decided to recode everything from scratch. So far that works fine.This may be related to the bug discussed earlier on this page, if that's the case it'll be fixed in the next release.
All stations display correctly at all times, including being snow-aware, having fences or depending on neighbouring tiles.
Every station, that sets 0x11, 0x14 and 0x15 to the same value for all bits, and where CB24 returns the one tile type only, works fine. But things fail when those bits are not set to the same and CB24 returns differing tile types depending on var 0x10 (i.e. 0x41 at construction).
Now, I have put together a Test GRF (It'll be in the mail shortly anyway), but the results are mixed. You may have a look at it anyway, otherwise things have to wait.If not I'll probably need a GRF which shows the problem to work out what the cause is.
Re: JGR's Patch Pack
Hello, i have question if it is decouple in this path?
Re: JGR's Patch Pack
Hello,
I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.
Bubu
I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.
Bubu
Re: JGR's Patch Pack
If you could post the savegame causing the issue I'll take a look at it.BubuSK wrote: ↑31 Dec 2023 10:17 Hello,
I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.
Bubu
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Wonderful ...Changelog v0.56.2 wrote: * Fix high-speed trains reversing at waypoints/behind signals failing to stop and reverse in some cases.
* Fix incorrect graphics/behaviour and blocked/wire/pylon states with certain rail station NewGRFs.
Thanks for fixing it. All works fine now.
Re: JGR's Patch Pack
Thank you JGR!JGR wrote: ↑31 Dec 2023 20:31If you could post the savegame causing the issue I'll take a look at it.BubuSK wrote: ↑31 Dec 2023 10:17 Hello,
I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.
Bubu
My savegame has 27MiB which is larger than max. filesize allowed here for attachments. I am therefore sharing link to the Google drive with the savegame file:
https://drive.google.com/file/d/135meP8 ... sp=sharing
Let me know if I can help further with testing
p.s. Happy New Year to everyone in the community!
Last edited by BubuSK on 31 Dec 2023 23:32, edited 1 time in total.
Re: JGR's Patch Pack
This seems to be caused by the industry set defining nonsense name suffixes for new stations placed near some industry types.BubuSK wrote: ↑31 Dec 2023 23:31Thank you JGR!JGR wrote: ↑31 Dec 2023 20:31If you could post the savegame causing the issue I'll take a look at it.BubuSK wrote: ↑31 Dec 2023 10:17 Hello,
I'd like to report I tried loading the savegame from 0.56.1 (which had the "Assertion failed at line 100 of /src/core/span_type.hpp: offset + count <= size()" error when trying to place a railway station) in the 0.56.2. Now the game throws the same error when attempting to load that savegame. I am running English (UK) localization.
Bubu
My savegame has 27MiB which is larger than max. filesize allowed here for attachments. I am therefore sharing link to the Google drive with the savegame file:
https://drive.google.com/file/d/135meP8 ... sp=sharing
Let me know if I can help further with testing
p.s. Happy New Year to everyone in the community!
I'll update the string handling in the next release so that a placeholder value is displayed instead of triggering a fatal error.
Last edited by JGR on 01 Jan 2024 18:59, edited 1 time in total.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
-
- Tycoon
- Posts: 1212
- Joined: 16 Oct 2018 08:31
- Location: Heart of the Highlands. Not Scottish. Czech.
Re: JGR's Patch Pack
Which industrial set is this? I'd rather pay attention to the update.
Who is online
Users browsing this forum: No registered users and 1 guest