Patch: Improved Breakdowns v2.4 (r14563)
Moderator: OpenTTD Developers
Re: Patch: Improved Breakdowns v2.4 (r14563)
Made a new version of patch... added vehicle news after train stuck crawling up the hill (because is to heavy). I know its have nothing to do with breakdowns... but after I added breakdown speed reduction such stuck train can break few times and then it will be big problem to unstuck rote.
Since there is many differences from IB 2.4 I think is time for new version IB 2.5 (hope Hirundo don't mind).
Patch Improved Breakdowns v2.5 (r18133) contains:
- Original patch IB 2.4
- additional speed reduction after mechanical failure (trains only)
- auto service in depot order after mechanical failure (to remove speed reduction)
- news about train stuck
Once again, if Hirundo is against that patch I will remove it or rename to something else.
Hope you test it and like it
Since there is many differences from IB 2.4 I think is time for new version IB 2.5 (hope Hirundo don't mind).
Patch Improved Breakdowns v2.5 (r18133) contains:
- Original patch IB 2.4
- additional speed reduction after mechanical failure (trains only)
- auto service in depot order after mechanical failure (to remove speed reduction)
- news about train stuck
Once again, if Hirundo is against that patch I will remove it or rename to something else.
Hope you test it and like it
- Attachments
-
- IBv2.5.patch
- Patch: Improved Breakdowns v2.5 (r18133)
- (60.5 KiB) Downloaded 202 times
Re: Patch: Improved Breakdowns v2.4 (r14563)
Thank you very much for keeping Hirundo's patch alive and even expanding it!
Without your work, I'm quite sure this patch would have been completely forgotten.
Without your work, I'm quite sure this patch would have been completely forgotten.
Re: Patch: Improved Breakdowns v2.4 (r14563)
Thx:) Unfortunately my "news upgrade" is not working corectly:/ news are show also when train is waiting before PBS . Just notice that... Thinking how to fix it.Tekky wrote:Thank you very much for keeping Hirundo's patch alive and even expanding it!
Without your work, I'm quite sure this patch would have been completely forgotten.
Re: Patch: Improved Breakdowns v2.4 (r14563)
I think I found solution. Here is patch file.
Edit: next bug...
To fix it replace 1 line in patch file:
to:
Edit: next bug...
To fix it replace 1 line in patch file:
Code: Select all
+ if (v->IsFrontEngine() && !(v->current_order_time & 0x1FF) && !(v->flags & (VRF_IS_BROKEN | (1 << VRF_TRAIN_STUCK))) && v->cur_speed < 3 && accel < 5) {
Code: Select all
+ if (v->IsFrontEngine() && !(v->current_order_time & 0x1FF) && !(v->current_order.IsType(OT_LOADING)) && !(v->flags & (VRF_IS_BROKEN | (1 << VRF_TRAIN_STUCK))) && v->cur_speed < 3 && accel < 5) {
- Attachments
-
- IB.patch
- IB2.5 (r18172)
- (60.65 KiB) Downloaded 174 times
Re: Patch: Improved Breakdowns v2.4 (r14563)
Merged with current trunk (r18408).
- Attachments
-
- IB_v2.5.patch
- Patch: Improved Breakdowns v2.5 (r18408)
- (60.47 KiB) Downloaded 180 times
Re: Patch: Improved Breakdowns v2.4 (r14563)
Merged to trunk (r18768) and fixed bug with planes (my mistake).
- Attachments
-
- IB.patch
- IB 2.5 (r18768)
- (60.11 KiB) Downloaded 193 times
Re: Patch: Improved Breakdowns v2.4 (r14563)
Merged to trunk (r19152). Apologies to bigos and Hirundo if I'm stepping on their toes. I use this with cargodist (note, not yet tested against it), and the recent changes to the train struct meant that the changes to train_cmd.cpp didn't apply cleanly at all. No new features in this patch. A word of warning: I haven't done any real work in C in about eight years, and I haven't tested it as thoroughly as I'd like.
- Attachments
-
- ib_r19152.diff
- IB 2.5 (r19152)
- (62.45 KiB) Downloaded 1953 times
Re: Patch: Improved Breakdowns v2.4 (r14563)
Thanks! You have now persuaded me to take another crack at patching OTTD myself. Once more unto the breach, dear friends. . .
Mackensen wrote:Merged to trunk (r19152). Apologies to bigos and Hirundo if I'm stepping on their toes. I use this with cargodist (note, not yet tested against it), and the recent changes to the train struct meant that the changes to train_cmd.cpp didn't apply cleanly at all. No new features in this patch. A word of warning: I haven't done any real work in C in about eight years, and I haven't tested it as thoroughly as I'd like.
Who is John Galt?
Re: Patch: Improved Breakdowns v2.4 (r14563)
I hope this patch will get into trunk sooner or later (though it seems that it's not as popular as e.g. infrastructure sharing or cargodest ).
*fingers crossed*
*fingers crossed*
Re: Patch: Improved Breakdowns v2.4 (r14563)
Hello! I like your patch very much, but I have a problem with it:
The problem is that when the train breaks with power breakdown it writes, that power down to 0% and starts to go very fast (at max. speed), but before break it goes slower for example at 110 km/h (depending of it weight). When the break ends, the train returns it real speed.
I'm playing the russian build with your patch. I'm using NARS 2 train set.
The problem is that when the train breaks with power breakdown it writes, that power down to 0% and starts to go very fast (at max. speed), but before break it goes slower for example at 110 km/h (depending of it weight). When the break ends, the train returns it real speed.
I'm playing the russian build with your patch. I'm using NARS 2 train set.
-
- Chief Executive
- Posts: 658
- Joined: 11 Nov 2007 12:06
- Contact:
Re: Patch: Improved Breakdowns v2.4 (r14563)
great work on updateing the patch
For Community Integrated Version http://code.google.com/p/civopenttd/
Re: Patch: Improved Breakdowns v2.4 (r14563)
Yes, what a pleasure to see this back again. I'm sure many of us feel there must be a good way to make reliability pay without the pain of "original" breakdowns.
Re: Patch: Improved Breakdowns v2.4 (r14563)
I'm sorry for being noob, but how do I install this for OTTD? Where do I put the .patch file?
Re: Patch: Improved Breakdowns v2.4 (r14563)
you get a compiler and then read the stickie topics in this forum.
Re: Patch: Improved Breakdowns v2.4 (r14563)
Or you can download Chillcore's Patchpack which has this in it along with so much more.
Something goes here, hell if I know.
Re: Patch: Improved Breakdowns v2.4 (r14563)
Or Hard Game pack 0.6 from Vaulter who updated the patch last timeComm Cody wrote:Or you can download Chillcore's Patchpack which has this in it along with so much more.
Re: Patch: Improved Breakdowns v2.4 (r14563)
I've ported it to the latest trunk version (r23640). I'll call it v2.5.1.
Maybe someone is hapy about this.
Maybe someone is hapy about this.
- Attachments
-
- ImprovedBreakdowns-v2.5.1-r23640.patch
- (61.14 KiB) Downloaded 249 times
- Vaulter
- Traffic Manager
- Posts: 185
- Joined: 21 Dec 2004 05:35
- Skype: andrey-zaharov
- Location: St. Petersburg, Russia
- Contact:
Re: Patch: Improved Breakdowns v2.4 (r14563)
something wrong with this patchviki2 wrote:I've ported it to the latest trunk version (r23640). I'll call it v2.5.1.
Maybe someone is hapy about this.
Re: Patch: Improved Breakdowns v2.4 (r14563)
Would you like to stat what is wrong with it?Vaulter wrote:something wrong with this patchviki2 wrote:I've ported it to the latest trunk version (r23640). I'll call it v2.5.1.
Maybe someone is hapy about this.
Do you like drones, quadcopters & flying toys? Check out Drone Strike Force!
Base Music Sets: OpenMSX | Scott Joplin Anthology | Traditional Winter Holiday Music | Modern Motion Music
Other Projects: 2CC Trams | Modern Waypoints | Sprite Sandbox & NewGRF Releases | Ideabox | Town Names | Isle of Sodor Scenario | Random Sprite Repository
Misc Topics: My Screenshots | Forgotten NewGRFs | Unfinished Graphics Sets | Stats Shack | GarryG's Auz Sets
Base Music Sets: OpenMSX | Scott Joplin Anthology | Traditional Winter Holiday Music | Modern Motion Music
Other Projects: 2CC Trams | Modern Waypoints | Sprite Sandbox & NewGRF Releases | Ideabox | Town Names | Isle of Sodor Scenario | Random Sprite Repository
Misc Topics: My Screenshots | Forgotten NewGRFs | Unfinished Graphics Sets | Stats Shack | GarryG's Auz Sets
Who is online
Users browsing this forum: Ahrefs [Bot] and 4 guests